FEATURE: Allow PHP 7 type declaration#79
Open
DanielSiepmann wants to merge 2 commits intoKonafets:developfrom
DanielSiepmann:feature/allow-php7-type-declaration
Open
FEATURE: Allow PHP 7 type declaration#79DanielSiepmann wants to merge 2 commits intoKonafets:developfrom DanielSiepmann:feature/allow-php7-type-declaration
DanielSiepmann wants to merge 2 commits intoKonafets:developfrom
DanielSiepmann:feature/allow-php7-type-declaration
Conversation
* Accordingly to http://php.net/manual/en/functions.arguments.php#functions.arguments.type-declaration We now allow also bool, float, int and string
Contributor
Author
|
Otherwise the following code will result in errors: |
Contributor
Author
|
Looks like the failing result is not due to the change? Or someone has to help me to understand the result so I can fix the broken part. |
Owner
|
Thanks for the PR! It seems something is wrong with PHPCS itself. I will have a look at this and your PR as well. |
Contributor
Author
|
Thanks for taking a look. I've also noticed that PHPCS or TYPO3SniffPool, don't know anymore which exactly, has issues with |
* As yield is nearly the same as return, we should allow phpdoc annotation, unless PSR is finished for PHPDocs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://php.net/manual/en/functions.arguments.php#functions.arguments.type-declaration
We now allow also bool, float, int and string